Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1693813003: Revert of [Testing] Run libaddressinput_unittests on bots (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
Reviewers:
Mathieu, Nico, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Testing] Run libaddressinput_unittests on bots (patchset #13 id:350001 of https://codereview.chromium.org/1681663002/ ) Reason for revert: Reverting, this caused the test to fail on the Dr Memory bots (where it was running fine prior to this change). https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20(DrMemory%20full)%20(3)/builds/9557/steps/memory%20test%3A%20addressinput/logs/stdio Original issue's description: > [Testing] Run libaddressinput_unittests on bots > > BUG=585151 > TEST=bots TBR=maruel@chromium.org,thakis@chromium.org,mathp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585151 Committed: https://crrev.com/5e2336653bc528b530c49f37db2bd1b650cc5b25 Cr-Commit-Position: refs/heads/master@{#375309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -172 lines) Patch
M build/gn_migration.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/chromium.win.json View 2 chunks +0 lines, -12 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 1 chunk +31 lines, -48 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +25 lines, -33 lines 0 comments Download
D third_party/libaddressinput/libaddressinput_unittests.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/libaddressinput/libaddressinput_unittests.isolate View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
Created Revert of [Testing] Run libaddressinput_unittests on bots
4 years, 10 months ago (2016-02-12 23:51:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813003/1
4 years, 10 months ago (2016-02-12 23:51:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813003/1
4 years, 10 months ago (2016-02-13 00:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813003/1
4 years, 10 months ago (2016-02-13 00:34:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813003/1
4 years, 10 months ago (2016-02-13 01:06:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-13 01:14:14 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:46:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e2336653bc528b530c49f37db2bd1b650cc5b25
Cr-Commit-Position: refs/heads/master@{#375309}

Powered by Google App Engine
This is Rietveld 408576698