Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1693813002: Make all GCs from memory reducer incremental. (Closed)

Created:
4 years, 10 months ago by ulan
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make all GCs from memory reducer incremental. BUG= Committed: https://crrev.com/ea39270193e27aeca34965ede0db8c05932dce04 Cr-Commit-Position: refs/heads/master@{#33940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M src/heap/memory-reducer.cc View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
ulan
PTAL.
4 years, 10 months ago (2016-02-12 10:05:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813002/1
4 years, 10 months ago (2016-02-12 11:10:50 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-12 11:10:52 UTC) #6
Hannes Payer (out of office)
On 2016/02/12 10:05:42, ulan wrote: > PTAL. Lgtm
4 years, 10 months ago (2016-02-12 11:12:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693813002/1
4 years, 10 months ago (2016-02-12 11:16:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 11:39:33 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 11:40:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea39270193e27aeca34965ede0db8c05932dce04
Cr-Commit-Position: refs/heads/master@{#33940}

Powered by Google App Engine
This is Rietveld 408576698