Put all XSAN bots on the same DEPS-sourced build of Clang.

Put all XSAN bots on the same DEPS-sourced build of Clang.

This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.

This is similar to how the CMake bots bootstrap CMake if needed.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693733003

Committed: https://skia.googlesource.com/skia/+/013475a27222c46e528c83704fa2bf43ba207571

[mtklein_C, 2016-02-12 19:15:38]

Description was changed from

==========
Put all XSAN bots on the same DEPS-sourced build of Clang.

This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.

This is similar to how the CMake bots bootstrap CMake if needed.

BUG=skia:
==========

to

==========
Put all XSAN bots on the same DEPS-sourced build of Clang.

This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.

This is similar to how the CMake bots bootstrap CMake if needed.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-02-12 19:52:25]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-02-12 19:52:26]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-02-12 19:52:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693733003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693733003/1

[commit-bot: I haz the power, 2016-02-12 19:52:37]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-02-13 01:52 UTC

[msarett, 2016-02-12 19:59:38]

lgtm

https://codereview.chromium.org/1693733003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1693733003/diff/1/DEPS#newcode54
DEPS:54: 
nit: extra line?

Maybe a comment could go here.

https://codereview.chromium.org/1693733003/diff/1/gyp/yasm.gyp
File gyp/yasm.gyp (right):

https://codereview.chromium.org/1693733003/diff/1/gyp/yasm.gyp#newcode67
gyp/yasm.gyp:67: 'cflags!': [ '-fsanitize=bounds',
'-fsanitize=<(skia_sanitizer)', '-fsanitize-memory-track-origins' ],
nit: 100 chars?

[commit-bot: I haz the power, 2016-02-12 20:15:26]

Description was changed from

==========
Put all XSAN bots on the same DEPS-sourced build of Clang.

This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.

This is similar to how the CMake bots bootstrap CMake if needed.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Put all XSAN bots on the same DEPS-sourced build of Clang.

This adds LLVM, Clang, and compiler-rt (*san tools) to DEPS,
then uses them from xsan_build, building them if needed.

This is similar to how the CMake bots bootstrap CMake if needed.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/013475a27222c46e528c83704fa2bf43ba207571
==========

[commit-bot: I haz the power, 2016-02-12 20:15:26]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/013475a27222c46e528c83704fa2bf43ba207571

[hal.canary, 2016-02-12 23:52:50]

halcanary@google.com changed reviewers:
+ halcanary@google.com

[hal.canary, 2016-02-12 23:52:51]

https://codereview.chromium.org/1693733003/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/1693733003/diff/1/DEPS#newcode56
DEPS:56: "third_party/externals/llvm/tools/clang":
"https://llvm.googlesource.com/clang@release_38",
Hold on!

If I am syncing out of order, and I clone into
`third_party/externals/llvm/tools/clang` first, how do I then clone
`third_party/externals/llvm`?  You can't clone into a non-empty directory.

[mtklein, 2016-02-13 00:29:27]

On 2016/02/12 23:52:51, Hal Canary wrote:
> https://codereview.chromium.org/1693733003/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/1693733003/diff/1/DEPS#newcode56
> DEPS:56: "third_party/externals/llvm/tools/clang":
> "https://llvm.googlesource.com/clang@release_38",
> Hold on!
> 
> If I am syncing out of order, and I clone into
> `third_party/externals/llvm/tools/clang` first, how do I then clone
> `third_party/externals/llvm`?  You can't clone into a non-empty directory.

gclient does it fine.