Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1693713005: Downstream impact from https://codereview.chromium.org/1693993002/ (Closed)

Created:
4 years, 10 months ago by iannucci
Modified:
4 years, 10 months ago
Reviewers:
dnj, luqui, martiniss, hinoka
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Downstream impact from https://codereview.chromium.org/1693993002/ This change makes git.checkout always do a rev-parse with step_text explaining what it just checked out. It also makes git.checkout return the commit hash that it checked out. R=dnj@chromium.org, hinoka@chromium.org, luqui@chromium.org, martiniss@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298775

Patch Set 1 #

Patch Set 2 : Roll dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+794 lines, -1 line) Patch
M infra/config/recipes.cfg View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/basic.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/discover.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/extra.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/missing.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/isolate/example.expected/none.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/example.expected/basic_0.4.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/example.expected/basic_0.5.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/example.expected/basic_0.5_show_isolated_out_in_collect_step.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming/example.expected/basic_0.5_show_shards_in_collect_step.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/swarming_client/example.expected/basic.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/flutter/flutter.expected/linux.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/flutter/flutter.expected/mac.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libvpx/android_unittests.expected/basic_linux_64.json View 2 chunks +26 lines, -0 lines 0 comments Download
M scripts/slave/recipes/libvpx/unittests.expected/basic_linux_64.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/perf/ct_top1k_perf.expected/CT_Top1k_RR.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/perf/ct_top1k_perf.expected/CT_Top1k_Repaint.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/perf/ct_top1k_perf.expected/CT_Top1k_slave1_empty_dir.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/perf/ct_top1k_perf.expected/CT_Top1k_slave2_failure.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/perf/ct_top1k_perf.expected/CT_Top1k_slave2_no_output.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_BENCH_10k_SKPs.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_2slaves_failure.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_Trybot.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_10k_SKPs_slave3_failure.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/ct_skps.expected/CT_DM_1m_SKPs.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/heartbeat.expected/heartbeat.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/swarming/heartbeat.expected/heartbeat_staging.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm_GC_Stress.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Arm___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64_GC_Stress___custom_snapshot.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___avx2.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___custom_snapshot___debug_slim_bisect_tester_swarming.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___avx2.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug___greedy_allocator_bisect_tester.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___deadcode.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug___avx2.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug___code_serializer.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug___greedy_allocator.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug___nosse3.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___debug___nosse4.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___gc_stress.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosnap___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosse3.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___nosse4.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux_bisect_tester_swarming.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_V8_Win32___debug.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng_triggered.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_dbg_ng_triggered.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux_rel_ng_triggered.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_rel_ng_triggered.json View 1 chunk +13 lines, -0 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win_rel_ng_triggered.json View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
iannucci
4 years, 10 months ago (2016-02-12 22:56:11 UTC) #1
dnj
lgtm
4 years, 10 months ago (2016-02-12 23:01:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693713005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693713005/20001
4 years, 10 months ago (2016-02-12 23:05:24 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 23:09:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298775

Powered by Google App Engine
This is Rietveld 408576698