ui/views/controls/button/custom_button.cc - Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Missed one call to SendFocusAlert Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/custom_button.cc

diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc

index 440ad93b7ead9cf696590cf5a94757284a282767..8caea1d0fb8d54742268962adbab3ba2d5f5b217 100644

--- a/ui/views/controls/button/custom_button.cc

+++ b/ui/views/controls/button/custom_button.cc

@@ -106,7 +106,7 @@ void CustomButton::SetHotTracked(bool is_hot_tracked) {

SetState(is_hot_tracked ? STATE_HOVERED : STATE_NORMAL);

if (is_hot_tracked)

- NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true);

+ NotifyAccessibilityEvent(ui::AX_EVENT_HOVER, true);

}

bool CustomButton::IsHotTracked() const {

« no previous file with comments | « ui/app_list/views/tile_item_view.cc ('k') | ui/views/controls/tree/tree_view.cc » ('j') | no next file with comments »