Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2201)

Unified Diff: ash/wm/overview/window_grid.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed one call to SendFocusAlert Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/window_grid.cc
diff --git a/ash/wm/overview/window_grid.cc b/ash/wm/overview/window_grid.cc
index 33fc3fe58dbdcae23d1ffd9cc81d077372c31c72..2036d5549b3510750f283e390630c809f1fb26a9 100644
--- a/ash/wm/overview/window_grid.cc
+++ b/ash/wm/overview/window_grid.cc
@@ -391,7 +391,7 @@ void WindowGrid::OnWindowDestroying(aura::Window* window) {
if (selected_index_ >= removed_index && selected_index_ != 0)
selected_index_--;
if (send_focus_alert)
- SelectedWindow()->SendFocusAlert();
+ SelectedWindow()->SendAccessibleSelectionEvent();
}
PositionWindows(true);
@@ -490,7 +490,7 @@ void WindowGrid::MoveSelectionWidget(WindowSelector::Direction direction,
InitSelectionWidget(direction);
// Send an a11y alert so that if ChromeVox is enabled, the item label is
// read.
- SelectedWindow()->SendFocusAlert();
+ SelectedWindow()->SendAccessibleSelectionEvent();
// The selection widget is moved to the newly selected item in the same
// grid.
MoveSelectionWidgetToTarget(animate);
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698