ash/wm/overview/window_selector_item.cc - Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_selector_item.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js » ('j') | ui/app_list/views/search_result_list_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/overview/window_selector_item.cc

diff --git a/ash/wm/overview/window_selector_item.cc b/ash/wm/overview/window_selector_item.cc

index a6b0f883510f9d04dc8738b67c271259e902c82c..fe9427ad651f360b71d5fd7237eac883f9119085 100644

--- a/ash/wm/overview/window_selector_item.cc

+++ b/ash/wm/overview/window_selector_item.cc

@@ -213,7 +213,8 @@ void WindowSelectorItem::RecomputeWindowTransforms() {

}

void WindowSelectorItem::SendFocusAlert() const {

- window_label_button_view_->NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true);

+ window_label_button_view_->NotifyAccessibilityEvent(

+ ui::AX_EVENT_SELECTION, true);

sky 2016/02/14 16:21:52 If the name of this method is correct, why send se

dmazzoni 2016/02/17 00:25:18 The name isn't right, the view isn't actually focu

}

void WindowSelectorItem::SetDimmed(bool dimmed) {