Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: ui/app_list/views/tile_item_view.cc

Issue 1693713004: Don't fire a FOCUS accessibility event on a View that doesn't have focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed one call to SendFocusAlert Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/app_list/views/start_page_view.cc ('k') | ui/views/controls/button/custom_button.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/tile_item_view.h" 5 #include "ui/app_list/views/tile_item_view.h"
6 6
7 #include "ui/app_list/app_list_constants.h" 7 #include "ui/app_list/app_list_constants.h"
8 #include "ui/app_list/views/app_list_main_view.h" 8 #include "ui/app_list/views/app_list_main_view.h"
9 #include "ui/views/background.h" 9 #include "ui/views/background.h"
10 #include "ui/views/controls/image_view.h" 10 #include "ui/views/controls/image_view.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 } 46 }
47 47
48 void TileItemView::SetSelected(bool selected) { 48 void TileItemView::SetSelected(bool selected) {
49 if (selected == selected_) 49 if (selected == selected_)
50 return; 50 return;
51 51
52 selected_ = selected; 52 selected_ = selected;
53 UpdateBackgroundColor(); 53 UpdateBackgroundColor();
54 54
55 if (selected) 55 if (selected)
56 NotifyAccessibilityEvent(ui::AX_EVENT_FOCUS, true); 56 NotifyAccessibilityEvent(ui::AX_EVENT_SELECTION, true);
57 } 57 }
58 58
59 void TileItemView::SetParentBackgroundColor(SkColor color) { 59 void TileItemView::SetParentBackgroundColor(SkColor color) {
60 parent_background_color_ = color; 60 parent_background_color_ = color;
61 UpdateBackgroundColor(); 61 UpdateBackgroundColor();
62 } 62 }
63 63
64 void TileItemView::SetHoverStyle(HoverStyle hover_style) { 64 void TileItemView::SetHoverStyle(HoverStyle hover_style) {
65 if (hover_style == HOVER_STYLE_DARKEN_BACKGROUND) { 65 if (hover_style == HOVER_STYLE_DARKEN_BACKGROUND) {
66 image_shadow_animator_.reset(); 66 image_shadow_animator_.reset();
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 // truncation in making the tooltip. We do not want the label itself to have a 145 // truncation in making the tooltip. We do not want the label itself to have a
146 // tooltip, so we only temporarily enable it to get the tooltip text from the 146 // tooltip, so we only temporarily enable it to get the tooltip text from the
147 // label, then disable it again. 147 // label, then disable it again.
148 title_->SetHandlesTooltips(true); 148 title_->SetHandlesTooltips(true);
149 bool handled = title_->GetTooltipText(p, tooltip); 149 bool handled = title_->GetTooltipText(p, tooltip);
150 title_->SetHandlesTooltips(false); 150 title_->SetHandlesTooltips(false);
151 return handled; 151 return handled;
152 } 152 }
153 153
154 } // namespace app_list 154 } // namespace app_list
OLDNEW
« no previous file with comments | « ui/app_list/views/start_page_view.cc ('k') | ui/views/controls/button/custom_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698