Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/core/SkDraw.cpp

Issue 1693683002: Change ScalarTo256 to more efficient implementation. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Assume SkScalar is floating point. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkDraw.cpp
diff --git a/src/core/SkDraw.cpp b/src/core/SkDraw.cpp
index e205ee45c07dec544b10020ec41a6b80c658d7f5..e63be30dbc616457c7b3363b069a249ac591addd 100644
--- a/src/core/SkDraw.cpp
+++ b/src/core/SkDraw.cpp
@@ -1761,14 +1761,7 @@ bool SkTriColorShader::TriColorShaderContext::setup(const SkPoint pts[], const S
#include "SkComposeShader.h"
static int ScalarTo256(SkScalar v) {
- int scale = SkScalarToFixed(v) >> 8;
- if (scale < 0) {
- scale = 0;
- }
- if (scale > 255) {
- scale = 255;
- }
- return SkAlpha255To256(scale);
+ return static_cast<int>(SkScalarPin(v, 0, 1) * 256);
mtklein 2016/02/12 18:34:44 4 space indent
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698