Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 169363007: Use factories instead of directly creating SkImageInfo. (Closed)

Created:
6 years, 10 months ago by bungeman-skia
Modified:
6 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Use factories instead of directly creating SkImageInfo. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=13480

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M include/core/SkSurface.h View 1 chunk +1 line, -4 lines 0 comments Download
M tests/DeferredCanvasTest.cpp View 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bungeman-skia
Using the factories means that these callers are no longer directly depending on the actual ...
6 years, 10 months ago (2014-02-17 16:41:15 UTC) #1
reed1
6 years, 10 months ago (2014-02-17 16:44:46 UTC) #2
reed1
lgtm
6 years, 10 months ago (2014-02-17 16:44:55 UTC) #3
bungeman-skia
6 years, 10 months ago (2014-02-17 17:02:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r13480.

Powered by Google App Engine
This is Rietveld 408576698