Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 16936002: [HTML Imports] Make HTMLLinkElement.import a Document. (Closed)

Created:
7 years, 6 months ago by Hajime Morrita
Modified:
7 years, 6 months ago
Reviewers:
dglazkov
CC:
blink-reviews, gavinp+prerender_chromium.org, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

[HTML Imports] Make HTMLLinkElement.import a Document. This follows spec change on https://www.w3.org/Bugs/Public/show_bug.cgi?id=22305 which asks imported fragment should be imported "document" to allow it to have URL and other APIs. BUG=240592 TEST=imported-document.html R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152614

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -48 lines) Patch
D LayoutTests/fast/html/imports/import-owner.html View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/fast/html/imports/import-owner-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/imported-document.html View 1 chunk +21 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/imported-document-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/resources/testharness.css View 0 chunks +-1 lines, --1 lines 1 comment Download
A + LayoutTests/http/tests/resources/testharness.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/resources/testharnessreport.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/html/HTMLImportsController.h View 4 chunks +2 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImportsController.cpp View 7 chunks +7 lines, -20 lines 0 comments Download
M Source/core/html/HTMLLinkElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLLinkElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Hajime Morrita
Could you take a look? Turning DocumentFragment back to Document.
7 years, 6 months ago (2013-06-13 07:27:35 UTC) #1
dglazkov
LGTM. I would really like for us to get a better sense from Elliott and ...
7 years, 6 months ago (2013-06-17 02:04:21 UTC) #2
Hajime Morrita
On 2013/06/17 02:04:21, Dimitri Glazkov wrote: > LGTM. I would really like for us to ...
7 years, 6 months ago (2013-06-17 02:15:57 UTC) #3
Hajime Morrita
Seeing no response so far. I'd land this and continue exploring current design.
7 years, 6 months ago (2013-06-18 07:05:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/16936002/1
7 years, 6 months ago (2013-06-18 07:05:27 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=1772
7 years, 6 months ago (2013-06-18 07:17:55 UTC) #6
Hajime Morrita
7 years, 6 months ago (2013-06-18 07:30:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r152614 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698