chrome/test/data/notifications/platform_notification_service.js - Issue 1693583002: Add browser test for notification action icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/notifications/platform_notification_service.js

Issue 1693583002: Add browser test for notification action icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ActionIconToJava

Patch Set: Rebase. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/notifications/platform_notification_service.html ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/notifications/platform_notification_service.js

diff --git a/chrome/test/data/notifications/platform_notification_service.js b/chrome/test/data/notifications/platform_notification_service.js

index 601dc2941df30ded5d1b0aa4a382b072dcf44a24..e7a3bf20eb628743b084eac3952f8e27990361d6 100644

--- a/chrome/test/data/notifications/platform_notification_service.js

+++ b/chrome/test/data/notifications/platform_notification_service.js

@@ -17,7 +17,12 @@ addEventListener('notificationclick', function (event) {

if (event.notification.title == 'action_close')

event.notification.close();

- messagePort.postMessage(event.notification.title);

+ var message = event.notification.title;

+ if (message == 'action_button_click')

+ message += ' ' + event.action;

+ messagePort.postMessage(message);

});

// The notificationclose event will be invoked when a persistent notification