chrome/browser/notifications/notification_ui_manager_android.cc - Issue 1693583002: Add browser test for notification action icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_ui_manager_android.cc

Issue 1693583002: Add browser test for notification action icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ActionIconToJava

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/notifications/platform_notification_service_browsertest.cc » ('j') | chrome/browser/notifications/platform_notification_service_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_ui_manager_android.cc

diff --git a/chrome/browser/notifications/notification_ui_manager_android.cc b/chrome/browser/notifications/notification_ui_manager_android.cc

index f757010a37b824807ef81d3c335d1e336e7af64c..f1b8dc5e81f09821c763b6d0255c96227b52a9fd 100644

--- a/chrome/browser/notifications/notification_ui_manager_android.cc

+++ b/chrome/browser/notifications/notification_ui_manager_android.cc

@@ -183,7 +183,7 @@ void NotificationUIManagerAndroid::Add(const Notification& notification,

Java_NotificationUIManager_displayNotification(

env, java_object_.obj(), persistent_notification_id, origin.obj(),

profile_id.obj(), profile->IsOffTheRecord(), tag.obj(), title.obj(),

- body.obj(), icon.obj(), vibration_pattern.obj(),

+ body.obj(), notification_icon.obj(), vibration_pattern.obj(),

notification.timestamp().ToJavaTime(), notification.renotify(),

notification.silent(), action_titles.obj(), action_icons.obj());