chrome/app/generated_resources.grd - Issue 1693583002: Add browser test for notification action icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app/generated_resources.grd

Side-by-side diff isn't available for this file because of its large size.

Issue 1693583002: Add browser test for notification action icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ActionIconToJava

Patch Set: Address johnme's comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: chrome/app/generated_resources.grd

diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd

index 046b361e2a183dadbd54a9538f2aeffdb2a458f2..9aa70b88f4cd45d3074eba81fcadb34894569be6 100644

--- a/chrome/app/generated_resources.grd

+++ b/chrome/app/generated_resources.grd

@@ -7976,6 +7976,12 @@ I don't think this site should be blocked!

Enable support for using the native notification toasts and notification center on platforms where these are available.

</message>

+ <message name="IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_NAME" desc="Name of the flag to enable notification action icons.">

+ Enable notification action icons.

Peter Beverloo 2016/02/12 11:47:24 It would be good to clarify that this is in contex

Michael van Ouwerkerk 2016/02/12 16:04:56 Done.

+ </message>

+ <message name="IDS_FLAGS_ENABLE_NOTIFICATION_ACTION_ICONS_DESCRIPTION" desc="Description of the flag to enable notification action icons.">

+ Enable support for icons in notification action buttons.

+ </message>

Fullscreen

</message>

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/notifications/platform_notification_service_browsertest.cc » ('J')