Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1693523002: [es6] More efficient way of marking AST call expressions in tail positions. (Closed)

Created:
4 years, 10 months ago by Igor Sheludko
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[es6] More efficient way of marking AST call expressions in tail positions. Instead of doing a full function body traversal we collect return expressions and mark them after function parsing. And since we rewrite do-expressions so that the result is explicitly assigned to a result variable the statements marking will never hit so I removed it from the AST. BUG=v8:4698 LOG=N Committed: https://crrev.com/d12dbab46618801b38430b614276002c178abf72 Cr-Commit-Position: refs/heads/master@{#33911}

Patch Set 1 : #

Patch Set 2 : Removed MarkTail() from Statement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -44 lines) Patch
M src/ast/ast.h View 1 10 chunks +0 lines, -37 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 7 chunks +58 lines, -6 lines 0 comments Download
M src/parsing/parser-base.h View 4 chunks +19 lines, -1 line 0 comments Download
M test/mjsunit/es6/tail-call.js View 2 chunks +156 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693523002/60001
4 years, 10 months ago (2016-02-11 14:31:23 UTC) #9
Igor Sheludko
PTAL
4 years, 10 months ago (2016-02-11 14:31:32 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/1243) v8_linux64_rel_ng_triggered on ...
4 years, 10 months ago (2016-02-11 14:54:31 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693523002/80001
4 years, 10 months ago (2016-02-11 15:27:27 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 16:23:57 UTC) #18
rossberg
lgtm
4 years, 10 months ago (2016-02-11 16:44:52 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693523002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693523002/80001
4 years, 10 months ago (2016-02-11 17:38:32 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 10 months ago (2016-02-11 17:39:53 UTC) #23
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 17:40:48 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d12dbab46618801b38430b614276002c178abf72
Cr-Commit-Position: refs/heads/master@{#33911}

Powered by Google App Engine
This is Rietveld 408576698