src/builtins.cc - Issue 1693513002: [runtime] Introduce FastNewStrictArgumentsStub to optimize strict arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins.cc

Issue 1693513002: [runtime] Introduce FastNewStrictArgumentsStub to optimize strict arguments. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix mips and mips64. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/builtins.cc

diff --git a/src/builtins.cc b/src/builtins.cc

index c0a0ef7fe2ac792e16ee99dd71607a46a5fccba9..465d7307c15721962083721acc2812069fce95b4 100644

--- a/src/builtins.cc

+++ b/src/builtins.cc

@@ -208,7 +208,7 @@ inline bool GetSloppyArgumentsLength(Isolate* isolate, Handle<JSObject> object,

Map* arguments_map = isolate->native_context()->sloppy_arguments_map();

if (object->map() != arguments_map) return false;

DCHECK(object->HasFastElements());

- Object* len_obj = object->InObjectPropertyAt(Heap::kArgumentsLengthIndex);

+ Object* len_obj = object->InObjectPropertyAt(JSArgumentsObject::kLengthIndex);

if (!len_obj->IsSmi()) return false;

*out = Max(0, Smi::cast(len_obj)->value());

return *out <= object->elements()->length();

« no previous file with comments | « src/bootstrapper.cc ('k') | src/code-factory.h » ('j') | no next file with comments »