Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1693463003: Track number of instances with a corrupt allocator. (Closed)

Created:
4 years, 10 months ago by bcwhite
Modified:
4 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track number of instances with a corrupt allocator. The existing indication of the number of allocations that failed due to a corrupt allocator doesn't provide much of use because it's impossible to tell across how many actual instances that is spread. This new code will be set only once per instance with corruption providing an important data point. BUG=546019 Committed: https://crrev.com/7529caf5d1881479ae1b99766cf8f5af9154204e Cr-Commit-Position: refs/heads/master@{#375625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M base/metrics/histogram_persistence.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bcwhite
4 years, 10 months ago (2016-02-11 18:31:52 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 10 months ago (2016-02-16 17:41:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693463003/1
4 years, 10 months ago (2016-02-16 18:06:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-16 19:37:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:54:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7529caf5d1881479ae1b99766cf8f5af9154204e
Cr-Commit-Position: refs/heads/master@{#375625}

Powered by Google App Engine
This is Rietveld 408576698