Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Issue 1693433003: webusb: Reject the promise if the device is already open. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
Reviewers:
juncai
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org, blink-reviews-api_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

webusb: Reject the promise if the device is already open. This change adds the necessary plumbing for the USB Mojo service implementation to detect when a device is already open and to report this error so that the WebUSB API can reject the promise returned by USBDevice::open() with an InvalidStateError. BUG=492204 Committed: https://crrev.com/01bda807e1f107f607b767281c62d5f9ddb582b0 Cr-Commit-Position: refs/heads/master@{#375003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M content/renderer/usb/web_usb_device_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M device/usb/mojo/device_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 1 chunk +13 lines, -4 lines 0 comments Download
M device/usb/public/interfaces/device.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBError.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/webusb/WebUSBError.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 10 months ago (2016-02-11 18:42:10 UTC) #2
juncai
LGTM.
4 years, 10 months ago (2016-02-11 19:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693433003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693433003/1
4 years, 10 months ago (2016-02-11 21:27:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 21:38:56 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:38:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01bda807e1f107f607b767281c62d5f9ddb582b0
Cr-Commit-Position: refs/heads/master@{#375003}

Powered by Google App Engine
This is Rietveld 408576698