public/web/WebSpeechGrammar.h - Issue 169343002: [WIP]Add WebPrivateHeapPtr and use it for speech platform layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebSpeechGrammar.h

Issue 169343002: [WIP]Add WebPrivateHeapPtr and use it for speech platform layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebSpeechGrammar.h

diff --git a/public/web/WebSpeechGrammar.h b/public/web/WebSpeechGrammar.h

index 6c6f1379fd070ac47e8d310a5981e5e8d47fa983..948f4f6e6b8c0c095044feba857334c261c81f4d 100644

--- a/public/web/WebSpeechGrammar.h

+++ b/public/web/WebSpeechGrammar.h

@@ -27,7 +27,7 @@

#define WebSpeechGrammar_h

#include "../platform/WebCommon.h"

-#include "../platform/WebPrivatePtr.h"

+#include "../platform/WebPrivateHeapPtr.h"

#include "../platform/WebURL.h"

namespace WebCore {

@@ -49,12 +49,12 @@ public:

BLINK_EXPORT void assign(const WebSpeechGrammar&);

#if BLINK_IMPLEMENTATION

- WebSpeechGrammar(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);

- WebSpeechGrammar& operator=(const WTF::PassRefPtr<WebCore::SpeechGrammar>&);

+ WebSpeechGrammar(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);

haraken 2014/02/17 09:04:57 Add explicit.

+ WebSpeechGrammar& operator=(const WTF::PassRefPtrWillBeRawPtr<WebCore::SpeechGrammar>&);

haraken 2014/02/17 09:04:57 Add explicit.

#endif

private:

- WebPrivatePtr<WebCore::SpeechGrammar> m_private;

+ WebPrivateHeapPtr<WebCore::SpeechGrammar> m_private;

haraken 2014/02/17 09:04:57 Shall we call this WebPrivateGarbageCollectedPtr ?

sof 2014/02/17 09:23:21 Alright; I'm splitting out this wrapper class into

};

} // namespace blink

« public/platform/WebPrivateHeapPtr.h ('K') | « public/platform/WebPrivateHeapPtr.h ('k') | public/web/WebSpeechInputResult.h » ('j') | no next file with comments »