chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc ('k') | chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

diff --git a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

index 4bac334c65e7b798ebc49295ccd3269023e2322d..0ca91fd1b90d77857ae96d13c53395a3f3d9f46f 100644

--- a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

+++ b/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

@@ -606,7 +606,7 @@ void ChromeUserManagerImpl::PerformPostUserLoggedInActions(

}

bool ChromeUserManagerImpl::IsDemoApp(const AccountId& account_id) const {

- return DemoAppLauncher::IsDemoAppSession(account_id.GetUserEmail());

+ return DemoAppLauncher::IsDemoAppSession(account_id);

}

bool ChromeUserManagerImpl::IsKioskApp(const AccountId& account_id) const {

@@ -1251,7 +1251,8 @@ bool ChromeUserManagerImpl::IsFirstExecAfterBoot() const {

void ChromeUserManagerImpl::AsyncRemoveCryptohome(

const AccountId& account_id) const {

cryptohome::AsyncMethodCaller::GetInstance()->AsyncRemove(

- account_id.GetUserEmail(), base::Bind(&OnRemoveUserComplete, account_id));

+ cryptohome::Identification(account_id),

+ base::Bind(&OnRemoveUserComplete, account_id));

}

bool ChromeUserManagerImpl::IsGuestAccountId(