chrome/browser/chromeos/login/saml/saml_browsertest.cc - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/saml/saml_browsertest.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/login_manager_test.cc ('k') | chrome/browser/chromeos/login/session/chrome_session_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/saml/saml_browsertest.cc

diff --git a/chrome/browser/chromeos/login/saml/saml_browsertest.cc b/chrome/browser/chromeos/login/saml/saml_browsertest.cc

index c98c80645cd0a51729b9f25ab8b137f1396bc400..9e8b69a1e15c5d21702834308adf8c8a9b2ba1de 100644

--- a/chrome/browser/chromeos/login/saml/saml_browsertest.cc

+++ b/chrome/browser/chromeos/login/saml/saml_browsertest.cc

@@ -280,7 +280,7 @@ class SecretInterceptingFakeCryptohomeClient : public FakeCryptohomeClient {

public:

SecretInterceptingFakeCryptohomeClient();

- void MountEx(const cryptohome::AccountIdentifier& id,

+ void MountEx(const cryptohome::Identification& id,

const cryptohome::AuthorizationRequest& auth,

const cryptohome::MountRequest& request,

const ProtobufMethodCallback& callback) override;

@@ -298,7 +298,7 @@ SecretInterceptingFakeCryptohomeClient::

}

void SecretInterceptingFakeCryptohomeClient::MountEx(

- const cryptohome::AccountIdentifier& id,

+ const cryptohome::Identification& id,

const cryptohome::AuthorizationRequest& auth,

const cryptohome::MountRequest& request,

const ProtobufMethodCallback& callback) {