chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed unit tests. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc ('k') | chrome/browser/chromeos/login/existing_user_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc

index 9ead3ef42fd40c5a2ab78b6548481268a89a28d6..2a61962dbd414db3653e6d93e97628eaa9ee1a29 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_remove_keys_operation.cc

@@ -47,9 +47,7 @@ void EasyUnlockRemoveKeysOperation::OnGetSystemSalt(

}

void EasyUnlockRemoveKeysOperation::RemoveKey() {

- const std::string canonicalized =

- gaia::CanonicalizeEmail(user_context_.GetAccountId().GetUserEmail());

- cryptohome::Identification id(canonicalized);

+ cryptohome::Identification id(user_context_.GetAccountId());

const Key* const auth_key = user_context_.GetKey();

cryptohome::Authorization auth(auth_key->GetSecret(), auth_key->GetLabel());