Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed unit tests. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
diff --git a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
index 13fe01e32f5978f31387237188fb1700214e65fd..ff4911b6f7e31ee1aaf7c4e883aa256b1078a6c3 100644
--- a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
+++ b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
@@ -266,10 +266,10 @@ class CryptohomeAuthenticatorTest : public testing::Test {
cryptohome::KeyDefinition::ProviderData("salt"));
key_definition.provider_data.back().bytes = std::move(salt);
}
- EXPECT_CALL(*mock_homedir_methods_,
- GetKeyDataEx(cryptohome::Identification(
- user_context_.GetAccountId().GetUserEmail()),
- kCryptohomeGAIAKeyLabel, _))
+ EXPECT_CALL(
+ *mock_homedir_methods_,
+ GetKeyDataEx(cryptohome::Identification(user_context_.GetAccountId()),
+ kCryptohomeGAIAKeyLabel, _))
.WillOnce(WithArg<2>(Invoke(
this, &CryptohomeAuthenticatorTest::InvokeGetDataExCallback)));
}
@@ -285,10 +285,10 @@ class CryptohomeAuthenticatorTest : public testing::Test {
kCryptohomeGAIAKeyLabel,
cryptohome::PRIV_DEFAULT));
}
- EXPECT_CALL(*mock_homedir_methods_,
- MountEx(cryptohome::Identification(
- user_context_.GetAccountId().GetUserEmail()),
- cryptohome::Authorization(auth_key), mount, _))
+ EXPECT_CALL(
+ *mock_homedir_methods_,
+ MountEx(cryptohome::Identification(user_context_.GetAccountId()),
+ cryptohome::Authorization(auth_key), mount, _))
.Times(1)
.RetiresOnSaturation();
}
@@ -562,8 +562,9 @@ TEST_F(CryptohomeAuthenticatorTest, DriveDataResync) {
// Set up mock async method caller to respond successfully to a cryptohome
// remove attempt.
mock_caller_->SetUp(true, cryptohome::MOUNT_ERROR_NONE);
- EXPECT_CALL(*mock_caller_,
- AsyncRemove(user_context_.GetAccountId().GetUserEmail(), _))
+ EXPECT_CALL(
+ *mock_caller_,
+ AsyncRemove(cryptohome::Identification(user_context_.GetAccountId()), _))
.Times(1)
.RetiresOnSaturation();
@@ -585,8 +586,9 @@ TEST_F(CryptohomeAuthenticatorTest, DriveResyncFail) {
// Set up mock async method caller to fail a cryptohome remove attempt.
mock_caller_->SetUp(false, cryptohome::MOUNT_ERROR_NONE);
- EXPECT_CALL(*mock_caller_,
- AsyncRemove(user_context_.GetAccountId().GetUserEmail(), _))
+ EXPECT_CALL(
+ *mock_caller_,
+ AsyncRemove(cryptohome::Identification(user_context_.GetAccountId()), _))
.Times(1)
.RetiresOnSaturation();
@@ -616,9 +618,10 @@ TEST_F(CryptohomeAuthenticatorTest, DriveDataRecover) {
// Set up mock async method caller to respond successfully to a key migration.
mock_caller_->SetUp(true, cryptohome::MOUNT_ERROR_NONE);
- EXPECT_CALL(*mock_caller_,
- AsyncMigrateKey(user_context_.GetAccountId().GetUserEmail(), _,
- transformed_key_.GetSecret(), _))
+ EXPECT_CALL(
+ *mock_caller_,
+ AsyncMigrateKey(cryptohome::Identification(user_context_.GetAccountId()),
+ _, transformed_key_.GetSecret(), _))
.Times(1)
.RetiresOnSaturation();
@@ -641,9 +644,10 @@ TEST_F(CryptohomeAuthenticatorTest, DriveDataRecoverButFail) {
// Set up mock async method caller to fail a key migration attempt,
// asserting that the wrong password was used.
mock_caller_->SetUp(false, cryptohome::MOUNT_ERROR_KEY_FAILURE);
- EXPECT_CALL(*mock_caller_,
- AsyncMigrateKey(user_context_.GetAccountId().GetUserEmail(), _,
- transformed_key_.GetSecret(), _))
+ EXPECT_CALL(
+ *mock_caller_,
+ AsyncMigrateKey(cryptohome::Identification(user_context_.GetAccountId()),
+ _, transformed_key_.GetSecret(), _))
.Times(1)
.RetiresOnSaturation();
@@ -732,8 +736,10 @@ TEST_F(CryptohomeAuthenticatorTest, DriveUnlock) {
// Set up mock async method caller to respond successfully to a cryptohome
// key-check attempt.
mock_caller_->SetUp(true, cryptohome::MOUNT_ERROR_NONE);
- EXPECT_CALL(*mock_caller_,
- AsyncCheckKey(user_context_.GetAccountId().GetUserEmail(), _, _))
+ EXPECT_CALL(
+ *mock_caller_,
+ AsyncCheckKey(cryptohome::Identification(user_context_.GetAccountId()), _,
+ _))
.Times(1)
.RetiresOnSaturation();
« no previous file with comments | « chrome/browser/chromeos/login/app_launch_controller.cc ('k') | chrome/browser/chromeos/login/chrome_restart_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698