Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1605)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing files. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/startup/startup_browser_creator.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator.cc b/chrome/browser/ui/startup/startup_browser_creator.cc
index d8b21e373beda1d3ab05db5f3a7c39fc3028cbe1..2b4db4d8bfa0046b9961ec0fb74d676edf625a9a 100644
--- a/chrome/browser/ui/startup/startup_browser_creator.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator.cc
@@ -672,6 +672,9 @@ bool StartupBrowserCreator::ProcessCmdLineImpl(
// If we are a demo app session and we crashed, there is no safe recovery
// possible. We should instead cleanly exit and go back to the OOBE screen,
// where we will launch again after the timeout has expired.
+ //
+ // TODO (alemate): kLoginUser value is no longer user e-mail. Make this check
+ // more correct.
if (chromeos::DemoAppLauncher::IsDemoAppSession(
command_line.GetSwitchValueASCII(chromeos::switches::kLoginUser))) {
chrome::AttemptUserExit();

Powered by Google App Engine
This is Rietveld 408576698