chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing files. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/app_launch_controller.cc ('K') | « chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc ('k') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_get_keys_operation.cc » ('j') | chrome/browser/chromeos/login/session/user_session_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc

diff --git a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc

index ea8a122005411fe58d40b9c1121d32082306318f..360e825ed2963f0f64888f4e5991005da1d6122a 100644

--- a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc

+++ b/chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc

@@ -355,9 +355,7 @@ void EasyUnlockCreateKeysOperation::OnGetSystemSalt(

kEasyUnlockKeyMetaNameWrappedSecret, device->wrapped_secret));

// Add cryptohome key.

- const std::string canonicalized =

- gaia::CanonicalizeEmail(user_context_.GetAccountId().GetUserEmail());

- cryptohome::Identification id(canonicalized);

+ const cryptohome::Identification id(user_context_.GetAccountId());

scoped_ptr<Key> auth_key(new Key(*user_context_.GetKey()));

if (auth_key->GetKeyType() == Key::KEY_TYPE_PASSWORD_PLAIN)