chromeos/dbus/utils.h - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/dbus/utils.h

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better condition in LOG_ASSERT in AccountId. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROMEOS_DBUS_UTILS_H_

	6 #define CHROMEOS_DBUS_UTILS_H_

	7

	8 namespace cryptohome {

	9 class Identification;

	10 class AccountIdentifier;

	11 }

	12

	13 namespace chromeos {

	14

	15 // Fill identification protobuffer.

	16 void FillIdentificationProtobuf(const cryptohome::Identification& id,

	17 cryptohome::AccountIdentifier* id_proto);
	stevenjb 2016/02/23 19:27:34 Can we name this file dbus_utils.h and namespace t Can we name this file dbus_utils.h and namespace this chromeos::dbus_utils? Searching the code for just 'utils.h' is problematic and the chromeos:: namespace is huge. (Or see other suggestion) Alexander Alekseev 2016/02/24 09:27:42 This function is now used in a single source file Show quoted text On 2016/02/23 19:27:34, stevenjb wrote: > Can we name this file dbus_utils.h and namespace this chromeos::dbus_utils? > Searching the code for just 'utils.h' is problematic and the chromeos:: > namespace is huge. > (Or see other suggestion) This function is now used in a single source file only, so I moved it there.
	18 } // namespace chromeos

	19

	20 #endif // CHROMEOS_DBUS_UTILS_H_

OLD	NEW

« chromeos/dbus/cryptohome_client.cc ('K') | « chromeos/dbus/session_manager_client.cc ('k') | chromeos/dbus/utils.cc » ('j') | chromeos/dbus/utils.cc » ('J')