chromeos/dbus/utils.cc - Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/dbus/utils.cc

Issue 1693383003: ChromeOS cryptohome should be able to use gaia id as user identifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Better condition in LOG_ASSERT in AccountId. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "chromeos/dbus/utils.h"

	6

	7 #include "chromeos/cryptohome/cryptohome_parameters.h"

	8 #include "chromeos/dbus/cryptohome/rpc.pb.h"

	9

	10 namespace chromeos {

	11

	12 void FillIdentificationProtobuf(const cryptohome::Identification& id,

	13 cryptohome::AccountIdentifier* id_proto) {

	14 id_proto->set_account_id(id.id());
	stevenjb 2016/02/23 19:27:34 Is there a reason this can't be a member of crypto Is there a reason this can't be a member of cryptohome::AccountIdentifier? Alexander Alekseev 2016/02/24 09:27:42 What do you mean? AccountIdentifier is autogenerat Show quoted text On 2016/02/23 19:27:34, stevenjb wrote: > Is there a reason this can't be a member of cryptohome::AccountIdentifier? What do you mean? AccountIdentifier is autogenerated from protobuf. stevenjb 2016/02/24 17:25:43 Ah, I see. It is too bad that isn't namespaced so Show quoted text On 2016/02/24 09:27:42, Alexander Alekseev wrote: > On 2016/02/23 19:27:34, stevenjb wrote: > > Is there a reason this can't be a member of cryptohome::AccountIdentifier? > > What do you mean? > AccountIdentifier is autogenerated from protobuf. Ah, I see. It is too bad that isn't namespaced so that we can more easily see that.
	15 }

	16

	17 } // namespace chromeos

OLD	NEW

« chromeos/dbus/utils.h ('K') | « chromeos/dbus/utils.h ('k') | chromeos/login/auth/authenticator.h » ('j') | chromeos/login/auth/cryptohome_authenticator.cc » ('J')