Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1693363002:
add a mechanism to define clang tarball mirrors (Closed)
|
Created:
4 years, 10 months ago by Mostyn Bramley-Moore Modified:
4 years, 10 months ago CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionadd a mechanism to define clang tarball mirrors
This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable
which can be used to override the default google storage api
URL from which clang tarballs are downloaded.
The goal here is to minimize load on the google storage mirrors,
which can become blocked for external contributors, since it is
apparently quite difficult to figure out why and how to get
un-blocked.
BUG=586146
Committed: https://crrev.com/9756e3ee8eb786f7806374e3862d173e1905a140
Cr-Commit-Position: refs/heads/master@{#375472}
Patch Set 1 #
Total comments: 2
Patch Set 2 : use Nico's much simpler suggestion #Messages
Total messages: 19 (8 generated)
mostynb@opera.com changed reviewers: + hans@chromium.org
@hans: please take a look. This change makes it possible for us to define local mirrors for clang tarballs. I will drop https://codereview.chromium.org/1688183004/ for now (use gsutil instead of downloading from https) since we have been unable to verify that it would help our problem (ie our build machines being blocked/throttled).
The CQ bit was checked by mostynb@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693363002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thakis@chromium.org changed reviewers: + thakis@chromium.org
https://codereview.chromium.org/1693363002/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1693363002/diff/1/tools/clang/scripts/update.... tools/clang/scripts/update.py:73: CDS_URL = 'https://commondatastorage.googleapis.com/chromium-browser-clang' Do you really need all this code? Isn't CDS_URL = os.environ.get('CDS_CLANG_BUCKET_OVERRIDE', 'https://commondatastorage.googleapis.com/chromium-browser-clang') in this line sufficient?
Description was changed from ========== add a mechanism to define clang tarball mirrors This patch adds an optional MIRROR_MAP environment variable, which makes it possible to define mirrors for clang tarball URLs. The form is: ORIGINAL_URL_PREFIX|MIRROR_PREFIX1[|MIRROR_PREFIX]* Multiple original URL prefixes may be specified, separated by whitespace. eg: export MIRROR_MAP="http://orig1/foo/|http:/mirror1/foo/ http://orig2/bar/|http://mirror1/bar/|http://mirror2/bar/" would first attempt to download from http:/mirror1/foo/ before trying http://orig1/foo/, and from http://mirror1/bar/ or http://mirror2/bar/ before trying http://orig2/bar/ The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 ========== to ========== add a mechanism to define clang tarball mirrors This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable which can be used to override the default google storage api URL from which clang tarballs are downloaded. The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 ==========
https://codereview.chromium.org/1693363002/diff/1/tools/clang/scripts/update.py File tools/clang/scripts/update.py (right): https://codereview.chromium.org/1693363002/diff/1/tools/clang/scripts/update.... tools/clang/scripts/update.py:73: CDS_URL = 'https://commondatastorage.googleapis.com/chromium-browser-clang' On 2016/02/15 15:13:47, Nico wrote: > Do you really need all this code? Isn't > > CDS_URL = os.environ.get('CDS_CLANG_BUCKET_OVERRIDE', > 'https://commondatastorage.googleapis.com/chromium-browser-clang') > > in this line sufficient? I implemented this using a local patch that was hastily cobbled together as a reference. For this file, I think your much simpler suggestion makes a lot of sense. There are a bunch of other googleapis.com URLs referenced in the tree, which might require similar patches, in which case some consolidation might be worthwhile. But we can worry about that later if it turns out to be a problem.
ps2 lgtm if it helps you
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693363002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693363002/20001
Thanks.
Message was sent while issue was closed.
Description was changed from ========== add a mechanism to define clang tarball mirrors This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable which can be used to override the default google storage api URL from which clang tarballs are downloaded. The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 ========== to ========== add a mechanism to define clang tarball mirrors This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable which can be used to override the default google storage api URL from which clang tarballs are downloaded. The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
lgtm2
Message was sent while issue was closed.
Description was changed from ========== add a mechanism to define clang tarball mirrors This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable which can be used to override the default google storage api URL from which clang tarballs are downloaded. The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 ========== to ========== add a mechanism to define clang tarball mirrors This patch adds a CDS_CLANG_BUCKET_OVERRIDE environment variable which can be used to override the default google storage api URL from which clang tarballs are downloaded. The goal here is to minimize load on the google storage mirrors, which can become blocked for external contributors, since it is apparently quite difficult to figure out why and how to get un-blocked. BUG=586146 Committed: https://crrev.com/9756e3ee8eb786f7806374e3862d173e1905a140 Cr-Commit-Position: refs/heads/master@{#375472} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9756e3ee8eb786f7806374e3862d173e1905a140 Cr-Commit-Position: refs/heads/master@{#375472} |
