Reland #2 Remove the is_loading_ field from WebContentsImpl

content/test/web_contents_observer_sanity_checker.cc

Index: content/test/web_contents_observer_sanity_checker.cc
diff --git a/content/test/web_contents_observer_sanity_checker.cc b/content/test/web_contents_observer_sanity_checker.cc
index 24b8ac945d9f258084c9f1923390a4d4c8a1312b..5290e191323ba410f32ce8eb168840f6627d6832 100644
--- a/content/test/web_contents_observer_sanity_checker.cc
+++ b/content/test/web_contents_observer_sanity_checker.cc
@@ -330,10 +330,25 @@ void WebContentsObserverSanityChecker::WebContentsDestroyed() {
   CHECK(active_media_players_.empty());
 }
 
+void WebContentsObserverSanityChecker::DidStartLoading() {
+  // TODO(clamy): add checks for the loading state in the rest of observer
+  // methods.
+  CHECK(!is_loading_);
+  CHECK(web_contents()->IsLoading());
+  is_loading_ = true;
+}
+
+void WebContentsObserverSanityChecker::DidStopLoading() {
+  CHECK(is_loading_);
+  CHECK(!web_contents()->IsLoading());
+  is_loading_ = false;
+}
+
 WebContentsObserverSanityChecker::WebContentsObserverSanityChecker(
     WebContents* web_contents)
-    : WebContentsObserver(web_contents), web_contents_destroyed_(false) {
-}
+    : WebContentsObserver(web_contents),
+      is_loading_(false),
+      web_contents_destroyed_(false) {}
 
 WebContentsObserverSanityChecker::~WebContentsObserverSanityChecker() {
   CHECK(web_contents_destroyed_);