content/renderer/history_controller.h - Issue 1693353002: Reland #2 Remove the is_loading_ field from WebContentsImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/history_controller.h

Issue 1693353002: Reland #2 Remove the is_loading_ field from WebContentsImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits + rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/history_controller.h

diff --git a/content/renderer/history_controller.h b/content/renderer/history_controller.h

index c8b00f2d33fda90be84e1bf6b7c1ebde3762ab81..451501c622413b51e69e74a2e80c443f61273cc7 100644

--- a/content/renderer/history_controller.h

+++ b/content/renderer/history_controller.h

@@ -117,7 +117,9 @@ class CONTENT_EXPORT HistoryController {

provisional_entry_ = std::move(entry);

}

- void GoToEntry(blink::WebLocalFrame* main_frame,

+ // Return true if the main frame ended up loading a request as part of the

+ // history navigation.

+ bool GoToEntry(blink::WebLocalFrame* main_frame,

scoped_ptr<HistoryEntry> entry,

scoped_ptr<NavigationParams> navigation_params,

blink::WebURLRequest::CachePolicy cache_policy);

« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/history_controller.cc » ('j') | no next file with comments »