Reland #2 Remove the is_loading_ field from WebContentsImpl

content/browser/frame_host/interstitial_page_impl.h

Index: content/browser/frame_host/interstitial_page_impl.h
diff --git a/content/browser/frame_host/interstitial_page_impl.h b/content/browser/frame_host/interstitial_page_impl.h
index 35bb4418d28571cc7444c4200c3563233df7adf6..9d8a9d2ae1519d9037e0d12c9ef18a5887e8d6d3 100644
--- a/content/browser/frame_host/interstitial_page_impl.h
+++ b/content/browser/frame_host/interstitial_page_impl.h
@@ -88,6 +88,8 @@ class CONTENT_EXPORT InterstitialPageImpl
   }
   bool reload_on_dont_proceed() const { return reload_on_dont_proceed_; }
 
+  bool pause_throbber() const { return pause_throbber_; }
+
   // TODO(nasko): This should move to InterstitialPageNavigatorImpl, but in
   // the meantime make it public, so it can be called directly.
   void DidNavigate(
@@ -271,10 +273,6 @@ class CONTENT_EXPORT InterstitialPageImpl
   // revert it to its original value).
   bool should_revert_web_contents_title_;
 
-  // Whether or not the contents was loading resources when the interstitial was
-  // shown.  We restore this state if the user proceeds from the interstitial.
-  bool web_contents_was_loading_;
-
   // Whether the ResourceDispatcherHost has been notified to cancel/resume the
   // resource requests blocked for the RenderViewHost.
   bool resource_dispatcher_host_notified_;
@@ -291,6 +289,11 @@ class CONTENT_EXPORT InterstitialPageImpl
 
   bool create_view_;
 
+  // Whether the throbber should be paused. This is true from the moment the
+  // interstitial is shown until the moment the interstitial goes away or the
+  // user choses to proceed.

[Charlie Reis, 2016/02/19 05:24:54]

nit: chooses

[clamy, 2016/02/19 12:02:05]

Done.

+  bool pause_throbber_;
+
   scoped_ptr<InterstitialPageDelegate> delegate_;
 
   scoped_refptr<SessionStorageNamespace> session_storage_namespace_;