Reland #2 Remove the is_loading_ field from WebContentsImpl

chrome/browser/extensions/extension_resource_request_policy_apitest.cc

Index: chrome/browser/extensions/extension_resource_request_policy_apitest.cc
diff --git a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
index 348f95839fb7eb3d7449073cb56ff3ab3955847d..bb5a30a0c2bb0d04e37cd990cbd7f1b56179abc2 100644
--- a/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
+++ b/chrome/browser/extensions/extension_resource_request_policy_apitest.cc
@@ -227,7 +227,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
       "web_accessible/accessible_history_navigation.html"));
   ui_test_utils::NavigateToURL(browser(), newtab_page);
   ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
-      browser(), accessible_newtab_override, 2);
+      browser(), accessible_newtab_override, 1);

[Charlie Reis, 2016/02/17 05:15:28]

What made this change?

[clamy, 2016/02/17 14:42:06]

If I remember correctly, there was a race involving a browser-initiated
navigation to a pending renderer starting and the current one stopping just
after that then another browser-initiated navigation starting, which resulted in
DidStopLoading and DidStartLoading being fired in the middle of that sequence.
Therefore they had to wait for 2 navigations. Since this case was fixed by the
patch, they only have to wait for one.

[Charlie Reis, 2016/02/17 23:34:26]

Acknowledged.

   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       browser()->tab_strip_model()->GetActiveWebContents(),
       "window.domAutomationController.send(document.title)",
@@ -246,8 +246,8 @@ IN_PROC_BROWSER_TEST_F(ExtensionResourceRequestPolicyTest,
   GURL accessible_linked_resource(embedded_test_server()->GetURL(
       "/extensions/api_test/extension_resource_request_policy/"
       "web_accessible/accessible_link_resource.html"));
-  ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(browser(),
-      accessible_linked_resource, 2);
+  ui_test_utils::NavigateToURLBlockUntilNavigationsComplete(
+      browser(), accessible_linked_resource, 1);
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       browser()->tab_strip_model()->GetActiveWebContents(),
       "window.domAutomationController.send(document.URL)",