ServiceWorker: Make ServiceWorkerStorage more self-defensive

ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
Committed: https://crrev.com/e35424b4497354a8995a5db765b3ba8b03314f4a
Cr-Commit-Position: refs/heads/master@{#375547}

[nhiroki, 2016-02-15 05:21:29]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for clients of the storage and asked them to access the storage
when it was disabled. However, the convention was not always obeyed and some
clients accessed the storage without the check.

This patch stops providing IsDisabled() to clients, and makes sure to abort
operations or to return an appropriate invalid value when it is disabled.

BUG=584606
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when it is disabled.

BUG=584606
==========

[nhiroki, 2016-02-15 05:21:39]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-02-15 06:07:13]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when it is disabled.

BUG=584606
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when it is disabled.

BUG=544022, 584606
==========

[nhiroki, 2016-02-15 08:10:12]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when it is disabled.

BUG=544022, 584606
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.

BUG=544022, 584606
==========

[nhiroki, 2016-02-15 08:19:29]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.

BUG=544022, 584606
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.

BUG=544022
==========

[nhiroki, 2016-02-15 08:20:00]

Patchset #1 (id:20001) has been deleted

[nhiroki, 2016-02-15 08:24:53]

Patchset #1 (id:40001) has been deleted

[nhiroki, 2016-02-15 08:25:00]

Patchset #1 (id:60001) has been deleted

[nhiroki, 2016-02-15 08:25:06]

Patchset #1 (id:80001) has been deleted

[nhiroki, 2016-02-15 08:27:31]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
availability for storage clients and asked them not to access the disabled
storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.

BUG=544022
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them not to access the
disabled storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

[nhiroki, 2016-02-15 08:35:03]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them not to access the
disabled storage. However, the convention was not always obeyed and some clients
accessed the storage without the check.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

[nhiroki, 2016-02-15 08:46:35]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to abort
operations or to return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

[nhiroki, 2016-02-15 08:47:29]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org

[nhiroki, 2016-02-15 08:47:29]

PTAL, thanks!

[falken, 2016-02-16 09:16:50]

lgtm, requiring clients to do things is dangerous...

https://codereview.chromium.org/1693303002/diff/100001/content/browser/servic...
File content/browser/service_worker/service_worker_storage.cc (right):

https://codereview.chromium.org/1693303002/diff/100001/content/browser/servic...
content/browser/service_worker/service_worker_storage.cc:1290:
disk_cache_->Disable();
Ah, nice bug.

[nhiroki, 2016-02-16 09:55:49]

The CQ bit was checked by nhiroki@chromium.org

[commit-bot: I haz the power, 2016-02-16 09:56:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1693303002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1693303002/100001

[commit-bot: I haz the power, 2016-02-16 11:05:58]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

[commit-bot: I haz the power, 2016-02-16 11:05:59]

Committed patchset #1 (id:100001)

[commit-bot: I haz the power, 2016-02-16 22:52:08]

Description was changed from

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022
==========

to

==========
ServiceWorker: Make ServiceWorkerStorage more self-defensive

Before this patch, ServiceWorkerStorage provided IsDisabled() to check the
storage availability for storage clients and asked them to check it before
accessing the storage. However, the convention was not always obeyed and some
clients sometimes accessed the disabled storage.

This patch stops providing IsDisabled() for the clients, and makes sure to fail
operations and return an appropriate error value when the storage is disabled.
The clients now no longer take care of the storage availability.

BUG=544022

Committed: https://crrev.com/e35424b4497354a8995a5db765b3ba8b03314f4a
Cr-Commit-Position: refs/heads/master@{#375547}
==========

[commit-bot: I haz the power, 2016-02-16 22:52:09]

Patchset 1 (id:??) landed as
https://crrev.com/e35424b4497354a8995a5db765b3ba8b03314f4a
Cr-Commit-Position: refs/heads/master@{#375547}