Implement PPB_HostResolver_Dev: part 2

Implement PPB_HostResolver_Dev: part 2

This CL:
- adds apps permission check;
- map net::Error to PP_Error.

BUG=247225
TEST=None
TBR=brettw@chromium.org
(TBR Brett because of renaming two files in content/content_browser.gypi)

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207366

[yzshen1, 2013-06-17 20:24:20]

Hi, Raymes and Cris.

Would you please take a look at this CL?

Raymes: Everything.

Cris: Please look at ppapi/proxy/ppapi_messages.h
This CL removes 'Private' from host resolver messages because they are now used
by both the public and private APIs. Besides, it changes to have two separate
create messages for public/private resources. (We will do different permission
check in the browser process based on the create message.)

I think this change should be pretty safe. Please feel free to ping me if you
need more context information.

Thank you!

[raymes, 2013-06-18 18:21:17]

lgtm

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/host_resolver_...
File ppapi/proxy/host_resolver_resource_base.cc (right):

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/host_resolver_...
ppapi/proxy/host_resolver_resource_base.cc:23: (pp_error <=
PP_ERROR_CONNECTION_CLOSED ||
nit: It would sort of be nicer to check whether this was in a range of errors
rather than below a certain error. Do we have a predefined range for net errors?
A utility function IsNetError would be even nicer.

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/ppapi_messages...
ppapi/proxy/ppapi_messages.h:1507:
IPC_MESSAGE_CONTROL2(PpapiHostMsg_HostResolver_Resolve,
nit: it would be nice to document these messages in the same way we have for the
other new APIs

[Cris Neckar, 2013-06-18 18:24:41]

lgtm on ipc messages

[yzshen1, 2013-06-18 19:08:43]

Thanks, Raymes and Cris!

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/host_resolver_...
File ppapi/proxy/host_resolver_resource_base.cc (right):

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/host_resolver_...
ppapi/proxy/host_resolver_resource_base.cc:23: (pp_error <=
PP_ERROR_CONNECTION_CLOSED ||
I agree with you that the current code doesn't look nice.

I am not quite sure how to define the ranges without starting a discussion in
the pepper group. If you are okay, I will add a TODO around here and do it
later.

Thanks!

On 2013/06/18 18:21:17, raymes wrote:
> nit: It would sort of be nicer to check whether this was in a range of errors
> rather than below a certain error. Do we have a predefined range for net
errors?
> A utility function IsNetError would be even nicer.

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/ppapi_messages.h
File ppapi/proxy/ppapi_messages.h (right):

https://codereview.chromium.org/16933003/diff/3001/ppapi/proxy/ppapi_messages...
ppapi/proxy/ppapi_messages.h:1507:
IPC_MESSAGE_CONTROL2(PpapiHostMsg_HostResolver_Resolve,
On 2013/06/18 18:21:17, raymes wrote:
> nit: it would be nice to document these messages in the same way we have for
the
> other new APIs

Done.

[commit-bot: I haz the power, 2013-06-19 17:17:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/16933003/18001

[commit-bot: I haz the power, 2013-06-19 17:22:40]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-06-19 17:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/16933003/18001

[commit-bot: I haz the power, 2013-06-19 17:34:10]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_cl...

[commit-bot: I haz the power, 2013-06-20 01:46:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/16933003/18001

[commit-bot: I haz the power, 2013-06-20 08:44:46]

Change committed as 207366