Issue 1693243002: Validate cache results in incremental resolution tests.

Issue 1693243002: Validate cache results in incremental resolution tests. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
skybrian, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Validate cache results in incremental resolution tests. It is OK to keep default parameter elements in the cache and so keep all the analysis results that depend on constants in the cache. Parameters don't use their offset in their locations, so they don't get "lost" during incremental resolution. R=brianwilkerson@google.com, skybrian@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8246f147e902ebd2d894636cdb934bb63507fd86

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -4 lines)			Patch
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		6 chunks	+77 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

scheglov

4 years, 10 months ago (2016-02-14 17:17:31 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8246f147e902ebd2d894636cdb934bb63507fd86 (presubmit successful).