Issue 169323004: Add agable@ to OWNERS

Issue 169323004: Add agable@ to OWNERS (Closed)

Created:
6 years, 10 months ago by agable

Modified:
6 years, 10 months ago

Reviewers:
iannucci, maurel, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add agable@ to OWNERS R=iannucci@chromium.org, maurel@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=252474

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	OWNERS	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

iannucci

On 2014/02/21 02:01:15, agable wrote: Not sure how many people need to +1, but this ...

6 years, 10 months ago (2014-02-21 02:02:52 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/169323004/1

6 years, 10 months ago (2014-02-21 02:36:55 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 10 months ago (2014-02-21 02:40:38 UTC) #6

commit-bot: I haz the power

Presubmit check for 169323004-1 failed and returned exit status 1. Running presubmit commit checks ...

6 years, 10 months ago (2014-02-21 02:40:38 UTC) #7

Presubmit check for 169323004-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/gclient_smoketest.py (172.70s) failed
......svn: Commit failed (details follow):
svn: Conflict at '/trunk'
EEE....EEE..............EE..EEEEEE...
======================================================================
ERROR: testMultiSolutions (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1229, in setUp
    self.enabled = self.FAKE_REPOS.set_up_svn() and self.FAKE_REPOS.set_up_git()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
353, in set_up_svn
    self.populateSvn()
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
504, in populateSvn
    self._commit_svn(fs)
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
395, in _commit_svn
    commit_svn(self.svn_checkout, self.USERS[0][0], self.USERS[0][1])
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
81, in commit_svn
    cwd=repo)
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 514, in
check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "/b/commit-queue/workdir/tools/depot_tools/subprocess2.py", line 477, in
check_call_out
    returncode, args, kwargs.get('cwd'), out[0], out[1])
CalledProcessError: Command svn commit /tmp/trialiLlD1N/repos/svn_checkout -m
foo --non-interactive --no-auth-cache --username user1@example.com --password
foo returned non-zero exit status 1 in /tmp/trialiLlD1N/repos/svn_checkout
Adding         origin
Adding         trunk
Adding         trunk/origin
Adding         trunk/other
Adding         trunk/other/origin
Adding         trunk/src
Adding         trunk/src/DEPS
Adding         trunk/src/DEPS.alt
Adding         trunk/src/origin
Adding         trunk/src/third_party
Adding         trunk/src/third_party/origin
Adding         trunk/third_party
Adding         trunk/third_party/foo
Adding         trunk/third_party/foo/origin
Adding         trunk/third_party/origin
Adding         trunk/third_party/prout
Adding         trunk/third_party/prout/origin
Transmitting file data ..........

======================================================================
ERROR: testMultiSolutionsJobs (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1288, in testMultiSolutionsJobs
    ('trunk/other@2', 'src/other')))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testMultiSolutionsMultiRev (__main__.GClientSmokeBoth)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1326, in testMultiSolutionsMultiRev
    ('trunk/third_party/foo@2', 'src/third_party/prout')))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testRevertAndStatus (__main__.GClientSmokeFromCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1444, in testRevertAndStatus
    ('trunk/third_party/foo@1', 'foo/bar'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testRunHooks (__main__.GClientSmokeFromCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1462, in testRunHooks
    ('trunk/third_party/foo@1', 'foo/bar'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSync (__main__.GClientSmokeFromCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 1421, in testSync
    ('trunk/third_party/foo@1', 'foo/bar'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testRevertAndStatus (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 553, in testRevertAndStatus
    ('trunk/other@2', 'src/other'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testRevertAndStatusDepsOs (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 623, in testRevertAndStatusDepsOs
    ('trunk/third_party/prout@2', 'src/third_party/prout'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSync (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 322, in testSync
    ('trunk/other@2', 'src/other'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSyncCustomDeps (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 489, in testSyncCustomDeps
    ('trunk/src/third_party@2', 'new_deps'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSyncCustomDepsNoDeps (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 518, in testSyncCustomDepsNoDeps
    ('trunk/other@2', 'src/other'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSyncIgnoredSolutionName (__main__.GClientSmokeSVN)
TODO(maruel): This will become an error soon.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 378, in testSyncIgnoredSolutionName
    ('trunk/other@2', 'src/other'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSyncJobs (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 422, in testSyncJobs
    ('trunk/other@2', 'src/other'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

======================================================================
ERROR: testSyncNoSolutionName (__main__.GClientSmokeSVN)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/gclient_smoketest.py", line 395, in testSyncNoSolutionName
    ('trunk/third_party/foo@2', 'src/third_party/prout'))
  File
"/b/commit-queue/workdir/tools/depot_tools/testing_support/fake_repos.py", line
818, in mangle_svn_tree
    tree = self.FAKE_REPOS.svn_revs[int(rev)]
IndexError: list index out of range

----------------------------------------------------------------------
Ran 43 tests in 171.602s

FAILED (errors=14)


Presubmit checks took 214.9s to calculate.

Was the presubmit check useful? If not, run "git cl pre…
(message too large)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/169323004/1

6 years, 10 months ago (2014-02-21 02:43:01 UTC) #10

Message was sent while issue was closed.

/me has the magic touch

:P

Expand Messages | Collapse Messages