chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 169323003: Implementation of leveldb-backed PrefStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 169323003: Implementation of leveldb-backed PrefStore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: respond to comments; add histograms.xml entries Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index b057bbcb2cad668acf33a4370897608fdf6735ec..4f6a15e832611689385bb9228c02479aa6fb738e 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -282,7 +282,8 @@ void HandleReadError(PersistentPrefStore::PrefReadError error) {

// an example problem that this can cause.

// Do some diagnosis and try to avoid losing data.

int message_id = 0;

- if (error <= PersistentPrefStore::PREF_READ_ERROR_JSON_TYPE) {

+ if (error <= PersistentPrefStore::PREF_READ_ERROR_JSON_TYPE ||

+ error == PersistentPrefStore::PREF_READ_ERROR_LEVELDB_CORRUPTION) {

message_id = IDS_PREFERENCES_CORRUPT_ERROR;

} else if (error != PersistentPrefStore::PREF_READ_ERROR_NO_FILE) {

message_id = IDS_PREFERENCES_UNREADABLE_ERROR;