chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 169323003: Implementation of leveldb-backed PrefStore

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 169323003: Implementation of leveldb-backed PrefStore (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: respond to comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index 1870de90c3a3a2dc17d7b94fd9f2dd4eab1c6336..77e680b2fe63b8fd38025c8a46c4d52dd832530e 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -281,7 +281,9 @@ void HandleReadError(PersistentPrefStore::PrefReadError error) {

// an example problem that this can cause.

// Do some diagnosis and try to avoid losing data.

int message_id = 0;

- if (error <= PersistentPrefStore::PREF_READ_ERROR_JSON_TYPE) {

+ if (error <= PersistentPrefStore::PREF_READ_ERROR_JSON_TYPE ||

+ error >=

+ PersistentPrefStore::PREF_READ_ERROR_LEVELDB_DESTROYED_REOPENED) {

message_id = IDS_PREFERENCES_CORRUPT_ERROR;

} else if (error != PersistentPrefStore::PREF_READ_ERROR_NO_FILE) {

message_id = IDS_PREFERENCES_UNREADABLE_ERROR;