Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: android_webview/renderer/aw_render_view_ext.cc

Issue 16932006: [Android WebView] Fix LoadsImagesAutomatically tests after crbug.com/224317 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restored WebPermissionClient inheritance Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_render_view_ext.cc
diff --git a/android_webview/renderer/aw_render_view_ext.cc b/android_webview/renderer/aw_render_view_ext.cc
index 8452b458f05621bfd606c004db669942927a94ac..08e1395b22fff06eb005dd6b39cef58f128437e3 100644
--- a/android_webview/renderer/aw_render_view_ext.cc
+++ b/android_webview/renderer/aw_render_view_ext.cc
@@ -167,21 +167,6 @@ void AwRenderViewExt::OnDocumentHasImagesRequest(int id) {
hasImages));
}
-bool AwRenderViewExt::allowImage(WebKit::WebFrame* frame,
- bool enabled_per_settings,
- const WebKit::WebURL& image_url) {
abarth-chromium 2013/06/13 18:20:10 Oh, it's great that you don't need this override a
joth 2013/06/14 00:25:25 Hmmm I looked again, and I'm not sure we don't? Th
- // Implementing setBlockNetworkImages, so allow local scheme images to be
- // loaded.
- if (enabled_per_settings)
- return true;
-
- // For compatibility, only blacklist network schemes instead of whitelisting.
- const GURL url(image_url);
- return !(url.SchemeIs(chrome::kHttpScheme) ||
- url.SchemeIs(chrome::kHttpsScheme) ||
- url.SchemeIs(chrome::kFtpScheme));
-}
-
void AwRenderViewExt::DidCommitProvisionalLoad(WebKit::WebFrame* frame,
bool is_new_navigation) {
content::DocumentState* document_state =
« android_webview/native/aw_settings.cc ('K') | « android_webview/renderer/aw_render_view_ext.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698