Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: android_webview/native/aw_settings.cc

Issue 16932006: [Android WebView] Fix LoadsImagesAutomatically tests after crbug.com/224317 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restored WebPermissionClient inheritance Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_settings.h" 5 #include "android_webview/native/aw_settings.h"
6 6
7 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h" 7 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h"
8 #include "android_webview/native/aw_contents.h" 8 #include "android_webview/native/aw_contents.h"
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 prefs.minimum_font_size = Java_AwSettings_getMinimumFontSizeLocked(env, obj); 149 prefs.minimum_font_size = Java_AwSettings_getMinimumFontSizeLocked(env, obj);
150 150
151 prefs.minimum_logical_font_size = 151 prefs.minimum_logical_font_size =
152 Java_AwSettings_getMinimumLogicalFontSizeLocked(env, obj); 152 Java_AwSettings_getMinimumLogicalFontSizeLocked(env, obj);
153 153
154 prefs.default_font_size = Java_AwSettings_getDefaultFontSizeLocked(env, obj); 154 prefs.default_font_size = Java_AwSettings_getDefaultFontSizeLocked(env, obj);
155 155
156 prefs.default_fixed_font_size = 156 prefs.default_fixed_font_size =
157 Java_AwSettings_getDefaultFixedFontSizeLocked(env, obj); 157 Java_AwSettings_getDefaultFixedFontSizeLocked(env, obj);
158 158
159 // Blink's LoadsImagesAutomatically and ImagesEnabled should be
joth 2013/06/13 17:27:14 nit: should -> must. (coupled with a bug link, I t
mnaganov (inactive) 2013/06/17 08:56:54 Done.
160 // set cris-cross to Android's. See
161 // https://code.google.com/p/chromium/issues/detail?id=224317#c26
159 prefs.loads_images_automatically = 162 prefs.loads_images_automatically =
163 Java_AwSettings_getImagesEnabledLocked(env, obj);
164 prefs.images_enabled =
160 Java_AwSettings_getLoadsImagesAutomaticallyLocked(env, obj); 165 Java_AwSettings_getLoadsImagesAutomaticallyLocked(env, obj);
161 166
162 prefs.images_enabled = Java_AwSettings_getImagesEnabledLocked(env, obj);
163
164 prefs.javascript_enabled = 167 prefs.javascript_enabled =
165 Java_AwSettings_getJavaScriptEnabledLocked(env, obj); 168 Java_AwSettings_getJavaScriptEnabledLocked(env, obj);
166 169
167 prefs.allow_universal_access_from_file_urls = 170 prefs.allow_universal_access_from_file_urls =
168 Java_AwSettings_getAllowUniversalAccessFromFileURLsLocked(env, obj); 171 Java_AwSettings_getAllowUniversalAccessFromFileURLsLocked(env, obj);
169 172
170 prefs.allow_file_access_from_file_urls = 173 prefs.allow_file_access_from_file_urls =
171 Java_AwSettings_getAllowFileAccessFromFileURLsLocked(env, obj); 174 Java_AwSettings_getAllowFileAccessFromFileURLsLocked(env, obj);
172 175
173 prefs.javascript_can_open_windows_automatically = 176 prefs.javascript_can_open_windows_automatically =
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) { 265 static jstring GetDefaultUserAgent(JNIEnv* env, jclass clazz) {
263 return base::android::ConvertUTF8ToJavaString( 266 return base::android::ConvertUTF8ToJavaString(
264 env, content::GetUserAgent(GURL())).Release(); 267 env, content::GetUserAgent(GURL())).Release();
265 } 268 }
266 269
267 bool RegisterAwSettings(JNIEnv* env) { 270 bool RegisterAwSettings(JNIEnv* env) {
268 return RegisterNativesImpl(env) >= 0; 271 return RegisterNativesImpl(env) >= 0;
269 } 272 }
270 273
271 } // namespace android_webview 274 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698