Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: src/a64/stub-cache-a64.cc

Issue 169303007: Revert r19403: "A64: Tidy up Push and Pop TODOs." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/a64/macro-assembler-a64-inl.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 // Generate call to api function. 747 // Generate call to api function.
748 void StubCompiler::GenerateFastApiCall(MacroAssembler* masm, 748 void StubCompiler::GenerateFastApiCall(MacroAssembler* masm,
749 const CallOptimization& optimization, 749 const CallOptimization& optimization,
750 Handle<Map> receiver_map, 750 Handle<Map> receiver_map,
751 Register receiver, 751 Register receiver,
752 Register scratch, 752 Register scratch,
753 bool is_store, 753 bool is_store,
754 int argc, 754 int argc,
755 Register* values) { 755 Register* values) {
756 ASSERT(!AreAliased(receiver, scratch)); 756 ASSERT(!AreAliased(receiver, scratch));
757 757 __ Push(receiver);
758 MacroAssembler::PushPopQueue queue(masm); 758 // Write the arguments to stack frame.
759 queue.Queue(receiver);
760 // Write the arguments to the stack frame.
761 for (int i = 0; i < argc; i++) { 759 for (int i = 0; i < argc; i++) {
760 // TODO(jbramley): Push these in as few Push() calls as possible.
762 Register arg = values[argc-1-i]; 761 Register arg = values[argc-1-i];
763 ASSERT(!AreAliased(receiver, scratch, arg)); 762 ASSERT(!AreAliased(receiver, scratch, arg));
764 queue.Queue(arg); 763 __ Push(arg);
765 } 764 }
766 queue.PushQueued();
767 765
768 ASSERT(optimization.is_simple_api_call()); 766 ASSERT(optimization.is_simple_api_call());
769 767
770 // Abi for CallApiFunctionStub. 768 // Abi for CallApiFunctionStub.
771 Register callee = x0; 769 Register callee = x0;
772 Register call_data = x4; 770 Register call_data = x4;
773 Register holder = x2; 771 Register holder = x2;
774 Register api_function_address = x1; 772 Register api_function_address = x1;
775 773
776 // Put holder in place. 774 // Put holder in place.
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
1553 1551
1554 // Miss case, call the runtime. 1552 // Miss case, call the runtime.
1555 __ Bind(&miss); 1553 __ Bind(&miss);
1556 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1554 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1557 } 1555 }
1558 1556
1559 1557
1560 } } // namespace v8::internal 1558 } } // namespace v8::internal
1561 1559
1562 #endif // V8_TARGET_ARCH_A64 1560 #endif // V8_TARGET_ARCH_A64
OLDNEW
« no previous file with comments | « src/a64/macro-assembler-a64-inl.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698