Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 169303006: Also compile A64 for quickcheck target (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Also compile A64 for quickcheck target We don't run tests yet because even in release mode, this will take a considerable amount of time. BUG=none R=ulan@chromium.org, machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19425

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Makefile View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-17 12:17:50 UTC) #1
jochen (gone - plz use gerrit)
PTAL
6 years, 10 months ago (2014-02-17 15:22:30 UTC) #2
ulan
lgtm
6 years, 10 months ago (2014-02-17 15:23:21 UTC) #3
Michael Achenbach
Is it important to compile release _and_ optdebug? Wouldn't just optdebug be enough to catch ...
6 years, 10 months ago (2014-02-17 19:58:16 UTC) #4
jochen (gone - plz use gerrit)
no, i don't think it's necessary, I just wanted to match the other platforms
6 years, 10 months ago (2014-02-17 20:12:40 UTC) #5
Sven Panne
https://codereview.chromium.org/169303006/diff/1/Makefile File Makefile (right): https://codereview.chromium.org/169303006/diff/1/Makefile#newcode362 Makefile:362: QUICKCHECKMODES = $(FASTTESTMODES),a64.release,a64.optdebug No need for a separate "make" ...
6 years, 10 months ago (2014-02-18 07:26:49 UTC) #6
jochen (gone - plz use gerrit)
updated
6 years, 10 months ago (2014-02-18 08:03:57 UTC) #7
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-18 08:53:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r19425 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698