Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 169303003: CSP 1.1: Revert CSSOM changes. (Closed)

Created:
6 years, 10 months ago by Mike West
Modified:
6 years, 10 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, mkwst+watchlist_chromium.org, rune+blink, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, ed+blinkwatch_opera.com, Inactive, watchdog-blink-watchlist_google.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

CSP 1.1: Revert CSSOM changes. In r166627 and r166494, we changed CSP 1.1 to block certain CSSOM operations if 'unsafe-eval' isn't present in a 'style-src' directive. This seems to be incompatible with the web; it broke every site using jQuery, GitHub, etc. It's not clear that we can (or want to) persue this change; reverting it for now while we chat about it again in the WG. BUG=336413, 343970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167321

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -378 lines) Patch
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csskeyframesrule-insertrule-allowed.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csskeyframesrule-insertrule-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csskeyframesrule-insertrule-blocked.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csskeyframesrule-insertrule-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssmediarule-insertrule-allowed.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssmediarule-insertrule-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssmediarule-insertrule-blocked.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssmediarule-insertrule-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstyledeclaration-csstext-allowed.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstyledeclaration-csstext-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstyledeclaration-csstext-blocked.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstyledeclaration-csstext-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstylesheet-insertrule-allowed.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstylesheet-insertrule-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstylesheet-insertrule-blocked.html View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/cssstylesheet-insertrule-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csssupportsrule-insertrule-allowed.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csssupportsrule-insertrule-allowed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csssupportsrule-insertrule-blocked.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/http/tests/security/contentSecurityPolicy/1.1/cssom/csssupportsrule-insertrule-blocked-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WorkerGlobalScopeCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSGroupingRule.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.cpp View 2 chunks +1 line, -13 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSStyleSheet.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/frame/ContentSecurityPolicy.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/frame/ContentSecurityPolicy.cpp View 15 chunks +16 lines, -48 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mike West
Mind stamping this revert? It wasn't a clean revert, so I'm waiting to see what ...
6 years, 10 months ago (2014-02-17 09:48:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-17 09:50:15 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-17 14:05:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/169303003/90001
6 years, 10 months ago (2014-02-17 14:05:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 17:27:45 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12802
6 years, 10 months ago (2014-02-17 17:27:46 UTC) #6
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 10 months ago (2014-02-18 07:56:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/169303003/90001
6 years, 10 months ago (2014-02-18 07:56:36 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 09:42:51 UTC) #9
Message was sent while issue was closed.
Change committed as 167321

Powered by Google App Engine
This is Rietveld 408576698