Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1693013002: Check bounds before casting float to integer in SamplePatch.cpp and SkBlurMaskFilter::CreateEmboss. (Closed)

Created:
4 years, 10 months ago by dogben
Modified:
4 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@unit-scalar-clamp-to-byte
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check bounds before casting float to integer in SamplePatch.cpp and SkBlurMaskFilter::CreateEmboss. BUG=skia:4632 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1693013002 Committed: https://skia.googlesource.com/skia/+/e7be3e5c7999230673c8272a2c73cb7261e735c6

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -30 lines) Patch
M samplecode/SamplePatch.cpp View 1 chunk +1 line, -13 lines 0 comments Download
M src/effects/SkEmbossMaskFilter.cpp View 1 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693013002/40001
4 years, 9 months ago (2016-02-25 18:58:20 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-02-25 19:23:58 UTC) #7
dogben
4 years, 9 months ago (2016-02-25 20:13:15 UTC) #9
mtklein
lgtm
4 years, 9 months ago (2016-03-01 21:25:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1693013002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1693013002/40001
4 years, 9 months ago (2016-03-01 21:30:03 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 21:44:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://skia.googlesource.com/skia/+/e7be3e5c7999230673c8272a2c73cb7261e735c6

Powered by Google App Engine
This is Rietveld 408576698