Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: test/unittests/interpreter/register-translator-unittest.cc

Issue 1692973002: Fix unittest for embedded constant pools. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add TODO comment. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/register-translator-unittest.cc
diff --git a/test/unittests/interpreter/register-translator-unittest.cc b/test/unittests/interpreter/register-translator-unittest.cc
index 85a82cb2816ea7c3c4d3bde632a2f0c16e324a26..e9f65a6af0b25429d84f2e78fa2cca0642f7e9b2 100644
--- a/test/unittests/interpreter/register-translator-unittest.cc
+++ b/test/unittests/interpreter/register-translator-unittest.cc
@@ -73,7 +73,9 @@ TEST_F(RegisterTranslatorTest, TestFrameSizeAdjustmentsForTranslationWindow) {
RegisterTranslator::RegisterCountAdjustment(173, 137));
EXPECT_EQ(window_width(),
RegisterTranslator::RegisterCountAdjustment(173, 137));
- EXPECT_EQ(0, RegisterTranslator::RegisterCountAdjustment(0, 120));
+ // TODO(oth): Add a kMaxParameters8 that derives this info from the frame.
+ int param_limit = FLAG_enable_embedded_constant_pool ? 119 : 120;
+ EXPECT_EQ(0, RegisterTranslator::RegisterCountAdjustment(0, param_limit));
EXPECT_EQ(window_limit(),
RegisterTranslator::RegisterCountAdjustment(0, 128));
EXPECT_EQ(window_limit(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698