Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Issue 1692973002: Fix unittest for embedded constant pools. (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
Reviewers:
oth, rmcilroy, Yang
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix unittest for embedded constant pools. Fixed frame size is larger when embedded constant pools are enabled. R=oth@chromium.org, rmcilroy@chromium.org, yangguo@chromium.org BUG= Committed: https://crrev.com/a53400523156b8d4825bda795241cadad040b2e7 Cr-Commit-Position: refs/heads/master@{#33985}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M test/unittests/interpreter/register-translator-unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
MTBrandyberry
This test started failing on PPC after https://codereview.chromium.org/1684073002. PTAL. I'm not sure whether somewhere else ...
4 years, 10 months ago (2016-02-12 16:20:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692973002/1
4 years, 10 months ago (2016-02-12 16:20:57 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 17:28:45 UTC) #5
oth
lgtm. https://codereview.chromium.org/1692973002/diff/1/test/unittests/interpreter/register-translator-unittest.cc File test/unittests/interpreter/register-translator-unittest.cc (right): https://codereview.chromium.org/1692973002/diff/1/test/unittests/interpreter/register-translator-unittest.cc#newcode76 test/unittests/interpreter/register-translator-unittest.cc:76: int param_limit = FLAG_enable_embedded_constant_pool ? 119 : 120; ...
4 years, 10 months ago (2016-02-12 17:33:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692973002/20001
4 years, 10 months ago (2016-02-12 21:40:50 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10913)
4 years, 10 months ago (2016-02-12 21:42:48 UTC) #11
rmcilroy
lgtm
4 years, 10 months ago (2016-02-15 10:05:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692973002/20001
4 years, 10 months ago (2016-02-15 10:06:13 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 10:37:26 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 10:38:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a53400523156b8d4825bda795241cadad040b2e7
Cr-Commit-Position: refs/heads/master@{#33985}

Powered by Google App Engine
This is Rietveld 408576698