Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1692873002: [turbofan] Enable tests for throwing into deopted code. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Enable tests for throwing into deopted code. The tests in question have been disabled because throwing into lazy deoptimized code was borked. After recent fixes landed these tests should now pass again. R=jarin@chromium.org TEST=cctest/test-run-deopt/DeoptExceptionHandler BUG=v8:4195 LOG=n Committed: https://crrev.com/81d2819c6ed197e79ded705fa08f6285f89a6bde Cr-Commit-Position: refs/heads/master@{#33937}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-deopt.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
Hey Jaro! These tests should pass after your awesome fix made it into the tree. ...
4 years, 10 months ago (2016-02-12 10:09:19 UTC) #1
Jarin
Awesome, lgtm!
4 years, 10 months ago (2016-02-12 10:32:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1692873002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1692873002/20001
4 years, 10 months ago (2016-02-12 10:48:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-12 10:50:01 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 10:50:30 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81d2819c6ed197e79ded705fa08f6285f89a6bde
Cr-Commit-Position: refs/heads/master@{#33937}

Powered by Google App Engine
This is Rietveld 408576698