Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: pkg/analyzer/lib/src/services/formatter_impl.dart

Issue 169283013: Support for removing empty statements (dartbug.com/16810). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/stmt_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer/lib/src/services/formatter_impl.dart (revision 32873)
+++ pkg/analyzer/lib/src/services/formatter_impl.dart (working copy)
@@ -137,13 +137,15 @@
var formattedSource = formatter.writer.toString();
- checkTokenStreams(startToken, tokenize(formattedSource));
+ checkTokenStreams(startToken, tokenize(formattedSource),
+ allowTransforms: options.codeTransforms);
return new FormattedSource(formattedSource, formatter.selection);
}
- checkTokenStreams(Token t1, Token t2) =>
- new TokenStreamComparator(lineInfo, t1, t2).verifyEquals();
+ checkTokenStreams(Token t1, Token t2, {allowTransforms: false}) =>
+ new TokenStreamComparator(lineInfo, t1, t2, transforms: allowTransforms).
+ verifyEquals();
ASTNode parse(CodeKind kind, Token start) {
@@ -185,8 +187,10 @@
final LineInfo lineInfo;
Token token1, token2;
+ bool allowTransforms;
- TokenStreamComparator(this.lineInfo, this.token1, this.token2);
+ TokenStreamComparator(this.lineInfo, this.token1, this.token2,
+ {transforms: false}) : this.allowTransforms = transforms;
/// Verify that these two token streams are equal.
verifyEquals() {
@@ -274,10 +278,23 @@
return true;
}
}
- // Advance past synthetic { } tokens
- if (isOPEN_CURLY_BRACKET(token2) || isCLOSE_CURLY_BRACKET(token2)) {
- token2 = token2.next;
- return checkTokens();
+
+ // Transform-related special casing
+ if (allowTransforms) {
+
+ // Advance past empty statements
+ if (isSEMICOLON(token1)) {
+ // TODO whitelist
+ token1 = token1.next;
+ return checkTokens();
+ }
+
+ // Advance past synthetic { } tokens
+ if (isOPEN_CURLY_BRACKET(token2) || isCLOSE_CURLY_BRACKET(token2)) {
+ token2 = token2.next;
+ return checkTokens();
+ }
+
}
return false;
@@ -722,7 +739,9 @@
}
visitEmptyStatement(EmptyStatement node) {
- token(node.semicolon);
+ if (!codeTransforms || node.parent is! Block) {
+ token(node.semicolon);
+ }
}
visitExportDirective(ExportDirective node) {
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/stmt_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698