Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 169283010: Revert debugging code in HdingWindowAnimationObserver (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+corewm_chromium.org
Visibility:
Public.

Description

Revert debugging code in HdingWindowAnimationObserver (https://codereview.chromium.org/150573007) The debugging code unfortunately did not produce any results. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -69 lines) Patch
M chrome/common/crash_keys.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/corewm/window_animations.cc View 3 chunks +11 lines, -61 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Scott, can you please take a look? I could not find any crashes with this ...
6 years, 10 months ago (2014-02-18 05:06:39 UTC) #1
sky
LGTM - did you still see the crash you were trying to track down?
6 years, 10 months ago (2014-02-18 17:38:06 UTC) #2
pkotwicz
Nope, the crash has mysteriously disappeared
6 years, 10 months ago (2014-02-18 17:49:49 UTC) #3
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-18 17:49:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169283010/1
6 years, 10 months ago (2014-02-18 17:50:26 UTC) #5
sky
You sure you don't want to leave it in for a little while longer until ...
6 years, 10 months ago (2014-02-18 17:50:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169283010/1
6 years, 10 months ago (2014-02-18 18:24:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169283010/1
6 years, 10 months ago (2014-02-18 18:32:23 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 20:51:22 UTC) #9
Message was sent while issue was closed.
Change committed as 251832

Powered by Google App Engine
This is Rietveld 408576698