Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/telemetry/PRESUBMIT.py

Issue 169283004: Introduce telemetry.web_components and a simple component-based Results object (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added HTML output, ready for review Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« DEPS ('K') | « DEPS ('k') | tools/telemetry/run_components_dev_server » ('j') | tools/telemetry/run_components_dev_server » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/PRESUBMIT.py
diff --git a/tools/telemetry/PRESUBMIT.py b/tools/telemetry/PRESUBMIT.py
index 4e485a6b6d63288057e53b99f5ae6c58a3ac35a9..4d8a03b103022ed0d59f737dd086e828dfe99e61 100644
--- a/tools/telemetry/PRESUBMIT.py
+++ b/tools/telemetry/PRESUBMIT.py
@@ -20,6 +20,12 @@ def _CommonChecks(input_api, output_api):
'Docs are stale. Please run:\n' +
'$ %s' % os.path.abspath(update_docs_path)))
+ # Importing telemetry.components actually brings tvcm into the path.
+ import telemetry.components # pylint: disable=W0612
+ from tvcm import presubmit_checker
+ checker = presubmit_checker.PresubmitChecker(input_api, output_api)
+ results += checker.RunChecks()
+
results.extend(input_api.canned_checks.RunPylint(
input_api, output_api,
black_list=PYLINT_BLACKLIST,
« DEPS ('K') | « DEPS ('k') | tools/telemetry/run_components_dev_server » ('j') | tools/telemetry/run_components_dev_server » ('J')

Powered by Google App Engine
This is Rietveld 408576698